Skip to content

Conversation

@manwar
Copy link

@manwar manwar commented Sep 1, 2019

Hi @mkende

Please review the PR.
https://cpants.cpanauthors.org/release/MATHIAS/App-Pfind-1.01

Many Thanks.
Best Regards,
Mohammad S Anwar

@mkende
Copy link
Owner

mkende commented Sep 1, 2019

Not having a POD there is a feature, as this package is an implementation details of the script so I wouldn't want it in the search result on CPAN. But PAUSE forces one package at least to be indexed as far as I understand. Let me know if you know of a better way to do this.

@manwar
Copy link
Author

manwar commented Sep 1, 2019

Since, you have "App::Pfind" as "NAME" in your Makefile.PL script, it expects you have abstract in the main pod.
Alternatively, you could make "pfind" as your NAME but then this would create distribution tarball like pfind-0.tar.gz. I am not sure if this is acceptable to you.
I am sure you have valid reason not to have any pod in App::Pfind but adding just NAME shouldn't hurt in my humble opinion.

@mkende
Copy link
Owner

mkende commented Sep 1, 2019

Renaming the distribution is perfectly fine if it solves this. I'll try that. Thanks for the tip.

@mkende
Copy link
Owner

mkende commented Sep 1, 2019

Can you clarify what tool is expecting this POD to exist and what is the impact of not having it? Reading the MakeMaker documentation (https://metacpan.org/pod/ExtUtils::MakeMaker#NAME1) it seems that the NAME in the Makefile.PL must point to a package associated with a .pm file (so it can't be pfind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants