Skip to content

Conversation

@khartahk
Copy link

@khartahk khartahk commented Nov 9, 2025

This PR should:

  • keep the users locale for home folders as they selected it when installing.
  • keep the users desktop environment as they choose it as all the config for that is already added to /etc/nixos/configuration.nix
  • fixes powerwash.desktop and other scripts to be also shown in Gnome
  • properly deletes all files in users home folder as the rm -rf ~/ said it didn't have access to delete that folder (unless we set it to run with sudo)

- keeps their locale for home folders
- keeps the desktop environemnt selected
- fixes `powerwash.desktop` and other application shortcuts to be shown
  in gnome
- properly deletes all hidden files in users home folder
@mkellyxp
Copy link
Owner

Hey @khartahk thanks for this PR. I'll have to spend some time to go over these as they're a bit bigger then little tweaks.

I'm def interested in the tweaks for locale, properly deleting files, and the powerwash scripts... however, the project heavily relies on the fact that this is the cinnamon desktop. It's like Linux mint in that way. It doesnt' really support the goals of the project to have lots of desktop spins of Nixbook, since MOST of Nixbook is basically just an opinionated take on cinnamon, with some systemd services to handle auto updates and upgrades.

I'll see if there is a simple and clean way to support multiple desktops without adding complication, weight or affecting stability. But if not, Nixbook will likely just be Cinnamon based.

It might also be do-able to keep the base.nix as cinnamon but make it conditional if you have a different DE set in the main config. Not sure yet!

@khartahk
Copy link
Author

Thanks, I'll try to add so cinnamon is the default and if you select something else from the current desktop lineout it won't use it.

@khartahk
Copy link
Author

khartahk commented Nov 10, 2025

I've added a check for the desktops that are available in the installer + plasma5. And if they are enabled it won't use these settings:

lib.mkIf = anyOtherDesktop {
    # Enable the X11 windowing system.
    services.xserver.enable = true;
    nixpkgs.config.allowUnfree = true;

    # Enable the Cinnamon Desktop Environment.
    services.xserver.displayManager.lightdm.enable = true;
    services.xserver.desktopManager.cinnamon.enable = true;
    xdg.portal.enable = true;
  };

since they are added in the configuration.nix by the installer. That should keep cinnamon as default for anyone following the manual install guide.

If you need I am opened for a live chat where I can explain why I added the changes and what exactly they do.

Sorry if I'm a bit to eager but I just cant help my self. I can try to slow down a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants