Draft
Conversation
Move the large operators appearing in some of Paul's examples to a separate data file in examples/.
Collaborator
|
@mkauers This is the outcome of a small student project under my supervision. The code looks quite good to me but there are still a few things that need checking before it can be merged. Paul is finishing his internship today and may not be able to make further changes himself, but I will try to review the code more thoroughly in the coming weeks and make any necessary fixes. Of course, if you want to take a look already, your comments are more than welcome! |
Owner
|
Thanks to you and Paul for this contribution. This looks like a useful
functionality. I will try to have a closer look. Are you suggesting that I
should wait with pulling until you are done with reviewing his code, or
shall I already pull the present version and integrate changes, if
necessary, later?
…On Wed, Jul 10, 2024 at 7:38 PM Marc Mezzarobba ***@***.***> wrote:
@mkauers <https://github.com/mkauers> This is the outcome of a small
student project under my supervision. The code looks quite good to me but
there are still a few things that need checking before it can be merged.
Paul is finishing his internship today and may not be able to make further
changes himself, but I will try to review the code more thoroughly in the
coming weeks and make any necessary fixes. Of course, if you want to take a
look already, your comments are more than welcome!
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD47XMZD6GSNXS2MACTXGNTZLVWPZAVCNFSM6AAAAABKVLOJVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGA4TGMJTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
I would suggest that you wait. |
fchapoton
reviewed
Aug 30, 2024
| described in the article. | ||
|
|
||
| EXAMPLES:: | ||
|
|
Contributor
There was a problem hiding this comment.
too much indented, should be 4 spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.