Improve sanity of trailing newline handling in command-line output #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had confused myself about why a trailing newline was necessary to see complete command-line output. It's due to an [npm bug][0], not any behavior of Node itself, and as such ought to be worked around in the npm scripts. However, whether this bug is present or not it's still good practice for most command outputs to end with a complete line (including `\n`), so all `pretty-*` notations have been updated to include a trailing newline. In the future I may decide to add additional `--output-format`s which use non-`pretty-*` notations so that users can get non-`\n`-terminated outputs from the runtime, but for now there's nothing new here. [0]: npm/cli#8583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had confused myself about why a trailing newline was necessary to see complete command-line output. It's due to an npm bug, not any behavior of Node itself, and as such ought to be worked around in the npm scripts.
However, whether this bug is present or not it's still good practice for most command outputs to end with a complete line (including
\n), so allpretty-*notations have been updated to include a trailing newline.In the future I may decide to add additional
--output-formats which use non-pretty-*notations so that users can get non-\n-terminated outputs from the runtime, but for now there's nothing new here.