Phase3 #40
Draft
Phase3 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A first attempt at an invariant
Co-authored-by: Tobias Wrigstad <tobias.wrigstad@it.uu.se>
Co-authored-by: Tobias Wrigstad <tobias.wrigstad@it.uu.se>
Co-authored-by: Tobias Wrigstad <tobias.wrigstad@it.uu.se>
Co-authored-by: Tobias Wrigstad <tobias.wrigstad@it.uu.se>
Co-authored-by: Tobias Wrigstad <tobias.wrigstad@it.uu.se>
Co-authored-by: Tobias Wrigstad <tobias.wrigstad@it.uu.se>
* Add a minimal CI * Apply static to internal functions. * Regened files and added a missing entry. * Change error to fix tests. * Manually allowing exception.
Add a flag for region awareness of a type.
Fix crash bug when invalid values are used to initiate a cown
This implements the addreference and remove reference logic for the dictionary. Adds a Py_CLEAR_OBJECT_FIELD to remove the reference in the correct point.
This makes the region invariant off by default, and requires configure to be passed: --with-region-invariant This then enables the invariant to run on every byte code instruction.
* Permitting key parts of Cowns to run without GIL * Cleaned up last check in test self.fail() is performed outside of the acquired cown
Adds a check to thread constructors ensuring that only cowns, immutables, and externally unique regions can be passed in as thread arguments.
Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com>
Phase 3: Check thread arguments
Update: actions/upload-artifact@v3 -> v4 (Phase 3)
* Cown release A cown will now be released: - When it is in pending-release state and its containing region closes - When a closed region, other cown or immutable object it stored in it - At the end of a @using if the cown's contained region can be closed * TODO => TODO Pyrona: Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com> * Remove GIL operations in release (since this operation cannot be contended) --------- Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
As far as I can see in the source code, tuples are always created in the local region (effectively), and get their arguments before they are assigned anywhere. So the only check added to set_item should always succeed. Leaving optimising this case for future work.
Spring Cleaning
Pyrona: Add and remove reference fixes in `PyObjectDict`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for checking the Phase 3 work.
📚 Documentation preview 📚: https://cpython-previews--40.org.readthedocs.build/