Variable normalization, dQdV, multicell comparisons, and multiplot graphing#1
Open
darkwraith wants to merge 33 commits intomjlacey:masterfrom
Open
Variable normalization, dQdV, multicell comparisons, and multiplot graphing#1darkwraith wants to merge 33 commits intomjlacey:masterfrom
darkwraith wants to merge 33 commits intomjlacey:masterfrom
Conversation
…rep expression to ignore plot tabs from xlsx files for users who genereate plots upon import.
…ween different cells.
…files of multiple cells for rate capability/polarization comparison.
…ring the normalization value in the generated list (raw, stats, norm). Allows for subsequent plotting functions to specify absolute capacity, specific capacity, areal capacity, or volumetric capacity.
…he normalization preferences available. Added section to select raw or stats based on which values are being plotted. *Note: this limits the flexibility of the plotting features. Chooses which axis labels depending on the normalization used. Also performs the normalization.
…lot using correct units.
…its. Also added data cleaning for I=0, and stagnant C/D capacity during D/C cycle to better match plotvp.
…on an NxN matrix. Code used from cookbook-r. Attribution http://www.cookbook-r.com/Graphs/Multiple_graphs_on_one_page_(ggplot2)/
Added a error expression for when user calls a normalization method that the data is not available. Fixed typo in normunits call upon plotting.
…acter strings. substitute/deparse not working correctly.
Set plot type from point to line for arbin_plotvp_multi to make consistent with arbin_plotvp. Made title optional for arbin_dQdV. sets to Null by default. Clarified the label variable in arbin_dQdV_multi to avoid confusion with the title.
Normalize
…asier mass data analysis.
During plotting convert to mAh as units suggest.
…on files. Include correct quotation usage ie: "t" and added the default info for size.
…vided more details for example usage for lapply example. Generate documentation.
…city/Volumetric Capacity to avoid confusion with charge/discharge capacity. Updated documentation.
… data. Multi cell data don't need titles because the cell labels are in the legend. Updated documentation to match. Fix #6
…yscale to the max and min value of the cell or all of the cells, but still allows for manual y range setting if extreme points are observed. Updated documentation to reflect changes. Fixes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first project on GitHub so I apologize in advance if this is merge request is a bit large. My main reason for this contribution was to allow for data normalization in a non-destructive manor and to be able to compare un-normalized capacity with areal, mass, and volume normalized data. This required a bit of work on the ploting side to get the units correct in axis labels as well.
Secondly, I added a differential capacity plot option with ability to manually change y-axis if needed due to noisy data.
Thirdly, I add "*_multi" versions of most plotting functions that compare one cycle between multiple cells.
Last, I added a multiplot function for combining multiple graphs into one figure.
As i mentioned this was my first real github contribution and I realize the pull request may be a bit large and sprawling. Please let me know if you have questions or prefer that I break up this submission into parts.
Thanks!