[pull] master from katspaugh:master#1
Open
pull[bot] wants to merge 574 commits intomjhubert:masterfrom
Open
Conversation
* destroy webaudio also for MediaElementWebAudio backend * updated changelog * rephrase Co-authored-by: Thijs Triemstra <info@collab.nl> Co-authored-by: marizuccara <mari.zuccara@mail.com>
…1928) * - removing private methods of plugins classes - added the possibility to inherit also the Region class - generalized access to wavesurfer's plugins properties, so the custom plugins can be defined with custom names * added changelog entry
* - splitted regions.js in two files, one for RegionsPlugin class, one for Region class, and moved both to plugin/regions dir - added findInDirectory function in the plugin build file, so the plugins entries can be found also if in deeper directories, recursively * added changelog and versioning * - renamed regions.js to index.js - updated the way of building plugins, in particular using parent directory name for the plugin when its name is index.js - updated versioning and comments * fixed merge mismatch in regions/index.js when instantiate Region class Co-authored-by: Thijs Triemstra <info@collab.nl> Co-authored-by: marizuccara <mari.zuccara@mail.com>
* Change Webpack config for Gatsby compatibility * Add Gatsby compatibility into changelog
* Added the ability to use a customized regions plugin in the `minimap` plugin through a new parameter `regionsPluginName` * updated changelog
* Outlines don't include x-axis In my original mod #478 the waveform min and max were initialized with the first sample, so that a min > 0 or a max < 0 were possible (e.g. for highly zoomed-in views). This got lost somewhere along the way; this change fixes it. * Add comments explaining min/max; note in CHANGES.md; modify zoom example to demonstrate. * Untabify.
…ck (#1949) * Update index.js Added doc for new Region property formatTimeCallback * Update region.js Added formatTimeCallback functionality * Update CHANGES.md Updated changelog
Co-authored-by: marizuccara <mari.zuccara@mail.com>
) * add splitChannelsOptions param * add splitChannelsOptions example * add filterChannels param in splitChannelOptions * add method to filter out channels from the waveform * draw empty waveform if all channels have been filtered out * add/clarify comments * add changelog and version number to setFilteredChannels Co-authored-by: Winnie Chen <win-chen@users.noreply.github.com>
* check if drawer wrapper exists before performs any operation on regions * changelog * changelog pull request id
…1956) * Perform null check when removing scroll listener * Fix typo
* Add option to seekTo method to allow diabling event emissions * Remove arrow functions and let declarations * Allow for disabling event handlers for any set of events via Observer#setDisabledEventEmissions * Forgot to remove old changes in Wavesurfer class * Add CHANGES.md entry for 4.0.0 * add version marker * add @example usage Co-authored-by: Thijs Triemstra <info@collab.nl>
* changelog * drawer: removed private methods and vars * fix changelog
* Fix muting behavior with the MediaElement backend * Document changes
* remove no-eslintrc flag this was breaking CI builds * fix lint errors that were re-exposed
* rewrite mediaelement-webaudio comment * resume audiocontext for Safari + mediaelement/webaudio this was happening in the webaudio backend, but due to the odd inheritance layout of mediaelement-webaudio it wasn't happening here. * add changelog entry * hoist common code into utility function * generalize comment
* update dev dependencies * bump version: 4.0.0
the regions plugin notably was using all the functions of Observer without calling the constructor, triggering a crash
show off playback of a region and looping.
Co-authored-by: Sishaar Rao <sishaar@nooks.in>
* regions new features: editableContent, removeButton with example how it works * fix #2521 request changes * add removeEventListener to each addEventListener --------- Co-authored-by: Thijs Triemstra <info@collab.nl>
* release: 6.5.0 * Rm duplicates in the changelog * Add a better description for funding.yml * Spelling
* Fix: github repo URL * Restore branch name
…ams (#2646) * Used setTimeout() method to require a minimum time period passes before redrawing/recalculating to reduce CPU requirements while zooming in on waveforms. Currently displaying a waveform image in example/zoom which will be used to hide the lack of wave drawing while zooming. * Implemented a backimage mimicking the wave to display zoom level faster TO DO: Hide the real wave while zooming Hide the backimage after zooming Zoom in on current timestamp while zooming on backimage FUTURE: Split or crop backimage for longer waves Re-render backimage to match the colour style of the wave with selected timestamp * Added hiding/showing of elements while zooming Since the coloured section of the wave is also handled by canvas objects within a wave I am going to move the backimage functionality into the canvasentry.js file so that each canvas handles it's own image, which should resolve the issue as well as segment the image into sections. * backimages are stored and drawn for each canvas entry. Current issue is the left offsets of each backimage are not being calculated correctly and images are overlapping. * Zooming now correctly handles progress positions. Creates backimages for progress wave Left offset of canvas elements are handled correctly. * Zooming out now works without any issues Zooming in needs a viewable region boundary implemented so that canvases don't become too large. Progress tracking and regions plugin work without any issues now. * Zoom optimisations have been made Canvases not in frame are cleared and not rendered Canvases that become too large are clipped Progress location is maintained * Added priority drawing for canvases in view Currently, changing zoom level before all canvases have been loaded causes issues, my next goal is to fix this by either improving the handling of missing canvases or preventing zoom change until all canvases have loaded. * Zoom slider locks up if rendering isn't finished I'll use and hopefully instead of locking up I can return to a backup render of the wave. * Allows zooming immediately after release This is done by cancelling loading and showing only loaded sections * Improved backup image that can handle large waves Zooming out on partially loaded waves loads a backup image, this features works regardless of wave size. * Optimisation checks if there is a wrapper With this change the branch now passes the included tests * Fixed issues with back image generation Low zoom level previously caused issue with back image generation, the issue has been resolved. * Added zooming to spectrogram example This will allow testing of the intended multicanvas implementation * Spectrogram successfully split into two canvases Canvases are equally sized Calculation is on the whole spectrogram and then converted to seperate canvases This is a starting point for scaling up to an adaptive number of canvases, similar to the multicanvas drawer used for the main wave. Ideally calculation can be moved such that it is done for each canvas, this would mean speed could be improved by calcuating visible spectrogram canvases. Right now this offers no noticeable speed improvement, but could improve the ability to display zoomable spectrograms without creating images too large for browsers. * Working for arbitrary number of canvases Image still generated first then split, limiting max size Committing a working version before attempting fix * spectrogram sections are generated per-canvas Currently trying to draw all canvases at once causes failure Next I'm going to implement staggering of the canvases to hopefully allowing further zooming even without performance improvements * Spectrogram can now display at unlimited width Fixed an issue where resample() was creating full-size arrays instead of limiting to the canvas size Fixed an issue where render() was being called twice as a result of an incorrect event fire in wavesurfer.js Removed placeholder text in zoom example * Spectrogram only draws viewable canvases After this I will implement delays rendering of low-priority canvases * Rearranged variables to allow for setting delays * Canvases stretch to zoom * Zoom now scales correctly against waveform Fixed issue where progress wasn't accurate during zoom * Improved zooming functionality for wavesurfer Removed functions that were no longer necessary backimages are no longer required, existing canvases are stretched during zoom. backup image is no longer required, canvases can continue rendering during the zooming process. * Implemented priority rendering for spectrogram Removed/changed comments referring to the removed backimage/backupimage * Added timeout clearing to prevent drawing old canvases after zoom level changes * Removed unecessary class variables * Patched in a fix so that original zooming behaviour is preserved Upon first call of the stretchCanvases() function the drawer will switch over to the optimised zoom functionality * Removed unecessary changes to formatting * Removed more unecessary changes --------- Co-authored-by: Luke Harrison <s4587520@student.uq.edu.au>
Co-authored-by: GitHub Actions <github@action>
* Chore: automate changelog * Update the readme wrt releasing * Fix changelog * Readme * Rm production, use master * Fix commit message * Fix sed * List syntax: * -> - * Exit on error --------- Co-authored-by: GitHub Actions <github@action>
* Release 6.6.0 * Update CHANGES.md
* Fix: NPM publish in the CI job * Test on this branch * Dependencies * Revert "Test on this branch" This reverts commit 5d9f92f. * if success()
* Fix: avoid exit 1 in CI script * Temp: test on this branch * Release 6.6.1 * Test release * Rm temp test
* remove marker by id * better implementation * remove extra whitespace
Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [engine.io](https://github.com/socketio/engine.io) from 6.4.1 to 6.4.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md) - [Commits](socketio/engine.io@6.4.1...6.4.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.3. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.2.2...4.2.3) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )