fix: update to correct list composers response#15
Open
jspeth wants to merge 1 commit intomjdierkes:mainfrom
Open
fix: update to correct list composers response#15jspeth wants to merge 1 commit intomjdierkes:mainfrom
jspeth wants to merge 1 commit intomjdierkes:mainfrom
Conversation
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files. Review in cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the response handling for the
listcommand.The response data is no longer an array. It's a dictionary containing a
composersfield:This fix adds a new type
ListBackgroundComposersResponsefor the response. Then in theComposerServicelist function, returns the responsecomposers.Summary by cubic
Updated the
listfunction inComposerServiceto handle the new response format, returning thecomposersarray from a response object instead of a raw array.ListBackgroundComposersResponsetype to match the updated API response.