fix: remove static on server block check #889
Merged
+74
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tylerjroach
commented
Jan 27, 2026
tylerjroach
commented
- Remove static on server block check
- Test improvements
rahul-mixpanel
requested changes
Jan 27, 2026
rahul-mixpanel
left a comment
rahul-mixpanel
left a comment
There was a problem hiding this comment.
requested one change. other than that, LGTM.
| * Sets the mIsServerBlocked field on an HttpService instance using reflection. | ||
| * This allows tests to set a known initial state before testing async behavior. | ||
| */ | ||
| private void setServerBlocked(HttpService service) throws Exception { |
There was a problem hiding this comment.
the default for the field "mIsServerBlocked" is false in the current code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.