Skip to content

Suppress warnings in elixir 1.18 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashimoto merged 2 commits into from
Dec 11, 2024
Merged

Suppress warnings in elixir 1.18 #4

nashimoto merged 2 commits into from
Dec 11, 2024
+12 −8

Conversation

@k-asm
Copy link
Member

@k-asm k-asm commented Dec 11, 2024

This PR includes changes to the CI config and refactoring to suppress compiler warnings in Elixir v1.18.

  • Updated the Elixir version in the matrix configs to include Elixir v1.18.
  • Module.eval_quoted/2 is deprecated.

@k-asm k-asm changed the title Suppress warnings in elixir 1.17 Suppress warnings in elixir 1.18 Dec 11, 2024
@k-asm k-asm mentioned this pull request Dec 11, 2024
Merged
@k-asm k-asm marked this pull request as ready for review December 11, 2024 02:50
tashirosota
tashirosota approved these changes Dec 11, 2024
View reviewed changes
Copy link

@tashirosota tashirosota left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nashimoto
nashimoto approved these changes Dec 11, 2024
View reviewed changes
Copy link

@nashimoto nashimoto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nashimoto nashimoto merged commit 1c1c272 into master Dec 11, 2024
30 checks passed
@nashimoto nashimoto deleted the work/support-elixir-1.18 branch December 11, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashimoto nashimoto nashimoto approved these changes

@tashirosota tashirosota tashirosota approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k-asm @nashimoto @tashirosota