Skip to content

Fixes _shouldUpdate Algorithm #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
undreeyyy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes _shouldUpdate Algorithm #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a57be9
Fixes should update algorithm
undreeyyy Jul 27, 2021
9676051
Merge pull request #1 from undreeyyy/hotfix/fix-should-update-algorithm
undreeyyy Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions lib/version_check.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
library version_check;

import 'dart:io';
import 'dart:convert';
import 'dart:io';

import 'package:flutter/material.dart';
import 'package:http/http.dart' as http;
import 'package:html/parser.dart' show parse;
import 'dart:math' as math;

import 'package:http/http.dart' as http;
import 'package:package_info/package_info.dart';
import 'package:url_launcher/url_launcher.dart';

Expand Down Expand Up @@ -163,18 +162,18 @@ Future<StoreVersionAndUrl?> _getMacStoreVersionAndUrl(String bundleId) async {
bool _shouldUpdate(String? packageVersion, String? storeVersion) {
if (packageVersion == storeVersion) return false;

final arr1 = packageVersion!.split('.');
final arr2 = storeVersion!.split('.');
final string1 = packageVersion!.replaceAll('.', '');
final string2 = storeVersion!.replaceAll('.', '');

for (int i = 0; i < math.min(arr1.length, arr2.length); i++) {
int? v1 = int.tryParse(arr1[i]);
int? v2 = int.tryParse(arr2[i]);
final v1 = int.tryParse(string1);
final v2 = int.tryParse(string2);

if (v1 == null || v2 == null) {
if (arr2[i].compareTo(arr1[i]) > 0) {
return true;
}
} else if (v2 > v1) {
if (v1 == null || v2 == null) {
if (string2.compareTo(string1) > 0) {
return true;
}
} else {
if (v2 > v1) {
return true;
}
}
Expand Down