Skip to content

Conversation

Copy link

Copilot AI commented Sep 22, 2025

This PR addresses the issue of outdated and incomplete documentation in the README.md model section by providing comprehensive coverage of all current entities and enums in the MetarParser project.

Issues Fixed

Incorrect Documentation:

  • Removed references to non-existent enums DepositBrakingCapacity and DepositThickness which are actually String fields in RunwayInfo, not enums
  • Fixed duplicate DepositType entry in the enumerations list
  • Corrected Wind class documentation to include the missing directionDegrees field and proper field types

Missing Documentation:

  • Added documentation for 4 new weather category enums that implement the WeatherCategory interface
  • Added documentation for the TemperatureDated class
  • Added comprehensive documentation for abstract classes and interfaces

New Model Classes Documented

Weather Categories

  • FAAWeatherCategory: US aviation weather categories (LIFR, IFR, MVFR, VFR) with detailed criteria
  • GAFORWeatherCategory: German aviation weather categories with reference to official DWD documentation
  • ICAOWeatherCategory: International aviation categories (IMC, VMC) based on ICAO standards
  • MilitaryWeatherCategory: Military color-coded categories (RED, AMB, YLO, GRN, WHT, BLU) with specific visibility/ceiling criteria

Additional Classes

  • TemperatureDated: Class for temperature readings with associated date and time information
  • WeatherCategory: Interface defining the contract for weather category implementations

Architecture Documentation

  • AbstractWeatherContainer: Base class providing common weather fields for METAR and TAF objects
  • AbstractWeatherCode: Parent class of METAR and TAF extending AbstractWeatherContainer
  • ITafGroups: Interface for TAF-specific elements like turbulence and icing

Enhancements

  • Added detailed descriptions and example values for key enums like Intensity, Phenomenon, and WeatherChangeType
  • Improved organization with separate sections for abstract classes vs concrete classes
  • Added reference links to official aviation standards for weather categories
  • Clarified which fields are optional and specified correct data types throughout

The documentation now accurately reflects the current codebase structure and provides developers with complete information about all available model entities, enums, and architectural components.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/MetarParser/MetarParser org.codehaus.plexus.classworlds.launcher.Launcher clean compile -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits September 22, 2025 21:21
Co-authored-by: mivek <9912558+mivek@users.noreply.github.com>
Co-authored-by: mivek <9912558+mivek@users.noreply.github.com>
@sonarqubecloud
Copy link

Copilot AI changed the title [WIP] Can you update the documentation of the project especially the model part with the new entities and enums Update README documentation with comprehensive model entities and enums Sep 22, 2025
Copilot AI requested a review from mivek September 22, 2025 21:25
@github-actions
Copy link

Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants