Open
Conversation
the rest of the code already: * uses "len" to check for overflow, * manually zero-terminates the "auxbuf" buffer. * calculates "len" as the difference of two pointers As a result, switching to memcpy() is safe. It's also faster, (for what that's worth) as strncpy() will check for zeros. Since we already used strlen() to bound the copying, the zero checks in strncpy() are not needed.
gahr
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects ban the use of strncpy(), as its' API is not safe. The use of strncpy() here is safe, but is not necessary.
Moving to memcpy() allows acutest to be used in projects which set build flags / macros / etc. that ban the use of insecure functions
The code already:
As a result, switching to memcpy() is safe. It's also faster, (for what that's worth) as strncpy() will check for zeros. Since we already used strlen() to bound the copying, the zero checks in strncpy() are not needed.