fix: cast int to size_t to quieten compilers.#76
Open
Melkor-1 wants to merge 1 commit intomity:masterfrom
Open
fix: cast int to size_t to quieten compilers.#76Melkor-1 wants to merge 1 commit intomity:masterfrom
Melkor-1 wants to merge 1 commit intomity:masterfrom
Conversation
In line 1831, a cast is required because `malloc()` expects a `size_t` as the first argument and an `int` was provided. The cast is perfectly safe here, as the number of tests can not be signed. Perhaps the better choice would have been to declare `acutest_list_size_` as an `unsigned` type. GCC-13.1 with -Wconversion complains about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line 1831, a cast is required because
malloc()expects asize_tas the first argument and anintwas provided. The cast is perfectly safe here, as the number of tests can not be signed. Perhaps the better choice would have been to declareacutest_list_size_as anunsignedtype. GCC-13.1 with-Wconversioncomplains about this.