cmake: make pre-built library discoverable via CMake configuration files #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
reviewed
Jan 20, 2024
ConnorBaker
force-pushed
the
feat/reusable-cmake
branch
from
316e211 to
da0962a
Compare
Author
|
I force-pushed to update the PR and take care of the extra |
wjakob
reviewed
Jan 23, 2024
Member
wjakob
left a comment
wjakob
left a comment
There was a problem hiding this comment.
A few more questions/followups (sorry, I'm not so familiar with the CMake install workflow)
ConnorBaker
force-pushed
the
feat/reusable-cmake
branch
2 times, most recently
from
e62ba9a to
a9535a7
Compare
Author
|
After reading through the CMake docs, I've switched to use |
Co-Authored-By: Someone Serge <sergei.kozlukov@aalto.fi>
ConnorBaker
force-pushed
the
feat/reusable-cmake
branch
from
a9535a7 to
dd0259f
Compare
wjakob
force-pushed
the
master
branch
3 times, most recently
from
7bfbde5 to
9d8b8bd
Compare
Member
|
Hi @ConnorBaker -- sorry for dropping the ball on this. Could I ask you to rebase this PR on top of master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work, started by @SomeoneSerge to add Mitsuba 3 to Nixpkgs: NixOS/nixpkgs#269378
This PR adds the ability to make
nanothreaddiscoverable via CMake instead of requiring projects vendor it in-tree.Additionally, it allows testing through CMake by using CTests