fix(app): use proper MaxWithdrawalsPerBlock for x/evmengine to prevent potential issues
#26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practically, there would be no issue even if we set
MaxWithdrawalsPerBlockto 0 because fallback logic in event procedures would not actually be called. We already have proper verification logic on the contract side (ValidatorManager.sol), soregisterValidatoranddepositCollateralwould always succeed.However, setting
MaxWithdrawalsPerBlockproperly would be better practice and prevent potential issues. Therefore, I will setMaxWithdrawalsPerBlockto 32.I don't think it would be a problem if we use different values for
MaxWithdrawalsPerBlockandWithdrawalLimit. I will use a hard-coded value (32) forMaxWithdrawalsPerBlock, whileWithdrawalLimitwill be managed in evmvalidator's parameters. We might use a value less than or equal to 32 for theWithdrawalLimit, so hard-codingMaxWithdrawalsPerBlockshould not be an issue.