Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 22, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
url-join ^4.0.0 -> ^5.0.0 age adoption passing confidence

Release Notes

jfromaniello/url-join (url-join)

v5.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/url-join-5.x branch 6 times, most recently from 62770a5 to fa96161 Compare May 22, 2025 11:30
@asajjad2 asajjad2 self-assigned this May 22, 2025
@renovate renovate bot force-pushed the renovate/url-join-5.x branch 9 times, most recently from 9bb0ff7 to b8b3863 Compare May 29, 2025 10:27
@renovate renovate bot force-pushed the renovate/url-join-5.x branch 12 times, most recently from 5765aba to a29294a Compare June 4, 2025 15:20
@renovate renovate bot force-pushed the renovate/url-join-5.x branch 2 times, most recently from becc45e to 90a2236 Compare June 7, 2025 07:51
@asajjad2 asajjad2 force-pushed the renovate/url-join-5.x branch from 90a2236 to a751b71 Compare June 10, 2025 11:28
@renovate
Copy link
Contributor Author

renovate bot commented Jun 10, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@asajjad2
Copy link
Contributor

asajjad2 commented Jun 10, 2025

url-join v5 switched to ESM-only but our Babel setup transpiles import statements to require() calls, which can't load ES modules. This was causing CI failures with ERR_REQUIRE_ESM errors.

Using dynamic import() to load the module at runtime bypasses this issue since it doesn't get transpiled by Babel. The component now loads url-join on runtime.

Alternative would be updating the whole build system to handle ESM imports natively, but that's more overhead than this simple fix.

@Anas12091101 Anas12091101 self-assigned this Jun 10, 2025
@Anas12091101
Copy link
Contributor

As discussed with @asajjad2 on the call, we’ve decided not to go ahead with the changes in a751b71. It’s not a critical update right now, and the extra state management would just add unnecessary overhead.

We’ve got other PRs waiting on ESM support as well (like #3513), so we’ll revisit and merge this once we’ve made the shift to ESM.

@Anas12091101 Anas12091101 removed their assignment Jun 10, 2025
@asajjad2 asajjad2 removed their assignment Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants