Update the build file to work on github in 2025 onwards

.github/workflows/continuous.yml

@@ -23,7 +23,8 @@ on:
   push:
     branches-ignore:
       - trash
-
+  workflow_dispatch: # This allows manual triggering of the workflow
+
 jobs:
   continuous:
     name: Run
@@ -43,21 +44,34 @@ jobs:
       NUKE_Configuration: ${{matrix.Configuration}}
       NUKE_Arch: ${{matrix.Arch}}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
           fetch-depth: 0
-          repository: mitchcapper/httrack-windows
+#          repository: mitchcapper/httrack-windows
+
       - name: Cache .nuke/temp, ~/.nuget/packages
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             .nuke/temp
             ~/.nuget/packages
           key: ${{ runner.os }}-${{ hashFiles('**/global.json', '**/*.csproj') }}
+
+#      - name: Ensure .NET 8 runtime is available
+#        uses: actions/setup-dotnet@v3
+#        with:
+#          dotnet-version: '8.0.x'
+#          package-type: 'dotnet-version'
+
+      - name: Show installed .NET runtimes (debug)
+        run: dotnet --list-runtimes
+
       - name: Run './build.cmd Pack'
         run: ./build.cmd Pack
-      - uses: actions/upload-artifact@v1
+      - uses: actions/upload-artifact@v4
         with:
           name: httrack-${{matrix.BaseImage}}-${{matrix.Configuration}}-${{matrix.Arch}}
           path: final
+
+

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "httrack"]
 	path = httrack
-	url = https://github.com/mitchcapper/httrack.git
+	url = https://github.com/xroche/httrack.git

WinHTTrack/OptionTab10.cpp

@@ -43,7 +43,7 @@ COptionTab10::COptionTab10() : CPropertyPage(COptionTab10::IDD)
 	m_proxy = _T("");
 	m_port = _T("");
 	m_ftpprox = FALSE;
-	m_sslproxy = TRUE;
+	m_sslproxy = FALSE;
 	//}}AFX_DATA_INIT
 }
 

build.ps1

@@ -18,7 +18,7 @@ $TempDirectory = "$PSScriptRoot\\.nuke\temp"
 
 $DotNetGlobalFile = "$PSScriptRoot\\global.json"
 $DotNetInstallUrl = "https://dot.net/v1/dotnet-install.ps1"
-$DotNetChannel = "Current"
+$DotNetChannel = "current"
 
 $env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE = 1
 $env:DOTNET_CLI_TELEMETRY_OPTOUT = 1

build/Build.cs

@@ -163,9 +163,11 @@ private IReadOnlyCollection<Output> OurMSBuild(Func<MSBuildSettings, MSBuildSett
 				//if (GitHubActions.Instance.Job.Contains("latest") == false)
 				//	forceFail = "CFLAGS=\" -D _WIN32\"";
 				LinConfigure($"--prefix=\"{OutputDirectory}\" {forceFail}", "httrack", logOutput: true, logInvocation: true);
-				LinMake("", "httrack", logOutput: true, logInvocation: true, customLogger: GCCLogHandler);
-				LinMake("install", "httrack", logOutput: true, logInvocation: true, customLogger: GCCLogHandler);
-
+// replaces: LinMake("", "httrack", logOutput: true, logInvocation: true);
+LinMake("", "httrack", logOutput: true, logInvocation: true);
+
+// replaces: LinMake("install", "httrack", logOutput: true, logInvocation: true);
+LinMake("install", "httrack", logOutput: true, logInvocation: true);
 
 
 
@@ -194,4 +196,3 @@ protected override void OnTargetFailed(string target) {
 
 		});
 }
-

build/NukePlusPlus/OurConfigurationEntity.cs

@@ -27,7 +27,7 @@ public enum PRIORITY { Normal, First}
 		public ConfigurationEntity after { get; set; }
 
 		protected OurGithubActionsJobWithMatrix job { get; private set; }
-		protected NukeBuild build => attribute.build;
+		protected System.Type build => attribute.build;
 		protected OurGitHubActionsAttribute attribute { get; private set; }
 		WRITE_LEVEL IConfigurationEntityHasLevel.level => _level;
 

build/NukePlusPlus/OurGitHubActionsAttribute.cs

@@ -15,18 +15,18 @@ namespace NukePlusPlus {
 	[PublicAPI]
 	[AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]
 	public class OurGitHubActionsAttribute : GitHubActionsAttribute {
-		public override ConfigurationEntity GetConfiguration(NukeBuild build, IReadOnlyCollection<ExecutableTarget> relevantTargets) {
-			this.build = build;
-			var orig = base.GetConfiguration(build, relevantTargets) as GitHubActionsConfiguration;
+		public override ConfigurationEntity GetConfiguration(IReadOnlyCollection<ExecutableTarget> relevantTargets) {
+			//this.build = build;
+			var orig = base.GetConfiguration(relevantTargets) as GitHubActionsConfiguration;
 			configuration.DetailedTriggers = orig.DetailedTriggers;
 			configuration.Jobs = orig.Jobs;
 			configuration.Name = orig.Name;
 			configuration.ShortTriggers = orig.ShortTriggers;
 			return configuration;
 		}
-		internal NukeBuild build;
+		internal Type build;
 		protected OurGitHubActionsConfiguration configuration=new();
-		public OurGitHubActionsAttribute(string name, params object[] vals) : base(name, GitHubActionsImage.MacOs1014) {
+		public OurGitHubActionsAttribute(string name, params object[] vals) : base(name, GitHubActionsImage.MacOs1015) {
 			job = new(this, configuration,  vals.Cast<Enum>().ToArray());
 			ActionName = name;
 		}

build/NukePlusPlus/OurGithubActionsJobWithMatrix.cs

@@ -51,7 +51,7 @@ public void PrepareForWrite() {
 				};
 				AllWriteItems.Insert(pos, newStep);
 			}
-			var oBuild = attribute.build as OurNukeBuild;
+			var oBuild = Activator.CreateInstance(attribute.build) as OurNukeBuild;
 			if (oBuild != null)
 				oBuild.DoWritingAdds(this);
 
@@ -117,15 +117,20 @@ void AddItemSorted(ConfigurationEntity entity) {
 
 		}
 		private void Configuration_OnGlobalWriteBegin(object sender, CustomFileWriter writer) {
+			Console.WriteLine("OurGithubActionsJobWithMatrix.Configuration_OnGlobalWriteBegin: entering");
 			AddNewItem<GithubMatrixOptionWriter>(matrixWriter => {
 				matrixWriter.InitialRange = MatrixOptions;
 				this.matrixWriter = matrixWriter;
 			}
 				);
+			Console.WriteLine("OurGithubActionsJobWithMatrix.Configuration_OnGlobalWriteBegin: about to PrepareForWrite");
 			PrepareForWrite();
+			Console.WriteLine("OurGithubActionsJobWithMatrix.Configuration_OnGlobalWriteBegin: returned from PrepareForWrite");
 			var global = AllWriteItems.Where(a => (a as IConfigurationEntityHasLevel)?.level == BaseOurConfigurationEntity.WRITE_LEVEL.Global).ToArray();
+			Console.WriteLine($"OurGithubActionsJobWithMatrix.Configuration_OnGlobalWriteBegin: global items count = {global.Length}");
 			foreach(var itm in global) {
 				AllWriteItems.Remove(itm);
+				Console.WriteLine($"OurGithubActionsJobWithMatrix: writing global item of type {itm.GetType().FullName}");
 				itm.Write(writer);
 			}
 		}

build/_build.csproj

@@ -2,24 +2,31 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net6.0</TargetFramework>
-    <RootNamespace></RootNamespace>
+    <TargetFramework>net8.0</TargetFramework>
+    <!-- Remove or set RootNamespace if needed -->
+    <!--<RootNamespace>Your.Namespace</RootNamespace>-->
     <NoWarn>CS0649;CS0169</NoWarn>
     <NukeRootDirectory>..</NukeRootDirectory>
     <NukeScriptDirectory>..</NukeScriptDirectory>
     <NukeTelemetryVersion>0</NukeTelemetryVersion>
+
+    <!-- Recommended modern settings -->
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+
+    <!-- Temporarily enable BinaryFormatter for Nuke/GitVersion compatibility -->
+    <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Nuke.Common" Version="6.1.2" />
+    <PackageReference Include="Nuke.Common" Version="7.0.6" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageDownload Include="GitVersion.Tool" Version="[5.10.3]" />
-  </ItemGroup>
+
 
   <ItemGroup>
-    <None Remove="..\.nuke\temp\**" />
+    <!-- use forward slashes for portability -->
+    <None Remove="../.nuke/temp/**" />
   </ItemGroup>
 
 </Project>