Skip to content

UnRARed-bug/mypinballs broken segment display command fix #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bosh wants to merge 2 commits into from
Closed

UnRARed-bug/mypinballs broken segment display command fix #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64286d4
fix: remove line breaking mypinballs segment displays
unRARed Feb 19, 2025
8d16363
update mypinballs test per corrected command delimiter format
bosh Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mpf/platforms/mypinballs/mypinballs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ def set_text(self, text: ColoredSegmentDisplayText, flashing: FlashingType, flas
# remove any non-numbers and spaces
text = re.sub(r'[^0-9 ]', "", text)

# special char for spaces
text = text.replace(" ", "?")
# set text
if flashing == FlashingType.FLASH_ALL:
cmd = b'2:'
Expand Down
14 changes: 7 additions & 7 deletions mpf/tests/test_MyPinballs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,23 +107,23 @@ def setUp(self):

def testPlatform(self):
self.serialMock.expected_commands = {
b'1:1:???1234': False,
b'1:1: 1234': False,
}
self.machine.segment_displays["display1"].add_text("1234", key="score")
self._wait_for_processing()
self.assertFalse(self.serialMock.expected_commands)

# change text (with same key)
self.serialMock.expected_commands = {
b'1:1:???1337': False,
b'1:1: 1337': False,
}
self.machine.segment_displays["display1"].add_text("1337", key="score")
self._wait_for_processing()
self.assertFalse(self.serialMock.expected_commands)

# change text (with same key)
self.serialMock.expected_commands = {
b'1:1:??42?23': False,
b'1:1: 42 23': False,
}
self.machine.segment_displays["display1"].add_text("42 23", key="score")
self._wait_for_processing()
Expand All @@ -138,28 +138,28 @@ def testPlatform(self):
self.assertFalse(self.serialMock.expected_commands)

self.serialMock.expected_commands = {
b'1:2:?424242': False,
b'1:2: 424242': False,
}
self.machine.segment_displays["display2"].add_text("424242")
self._wait_for_processing()
self.assertFalse(self.serialMock.expected_commands)

self.serialMock.expected_commands = {
b'2:2:?424242': False,
b'2:2: 424242': False,
}
self.machine.segment_displays["display2"].set_flashing(FlashingType.FLASH_ALL)
self._wait_for_processing()
self.assertFalse(self.serialMock.expected_commands)

self.serialMock.expected_commands = {
b'1:2:?424242': False,
b'1:2: 424242': False,
}
self.machine.segment_displays["display2"].set_flashing(FlashingType.NO_FLASH)
self._wait_for_processing()
self.assertFalse(self.serialMock.expected_commands)

self.serialMock.expected_commands = {
b'4:2:?424242': False,
b'4:2: 424242': False,
}
self.machine.segment_displays["display2"].set_flashing(FlashingType.FLASH_MATCH)
self._wait_for_processing()
Expand Down
Loading