Skip to content

Fix shot#persist_enable=false#1896

Draft
bosh wants to merge 3 commits intomissionpinball:devfrom
bosh:test_shot_persist_enable
Draft

Fix shot#persist_enable=false#1896
bosh wants to merge 3 commits intomissionpinball:devfrom
bosh:test_shot_persist_enable

Conversation

@bosh
Copy link
Collaborator

@bosh bosh commented Jun 6, 2025

It seems that the enabled status is persisted whether you like it or not. I have a test case that passes for other property combinations, but not this one. Need to still figure out the root cause/fix

@sonarqubecloud
Copy link

@bosh bosh force-pushed the test_shot_persist_enable branch from 2821c41 to 0e64c48 Compare November 8, 2025 02:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2025

@bosh bosh force-pushed the test_shot_persist_enable branch from 0e64c48 to 3dd7431 Compare February 14, 2026 05:56
bosh added 3 commits February 16, 2026 01:58
note that one assertion is commented because it fails
and I believe this is a bug. This commit serves to show
that the rest of the test passes, and the next commit
will fail it.
@bosh bosh force-pushed the test_shot_persist_enable branch from 3dd7431 to 6349357 Compare February 16, 2026 09:59
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant