Skip to content

Segment display replace #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpcarr wants to merge 3 commits into
base: dev
Choose a base branch
from
+8 −1
Open

Segment display replace #1840

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0ede2f
use current state flashing and color props on replace
mpcarr Sep 22, 2024
5d57b8c
Removes the text from the display if update method is not stack
mpcarr Sep 22, 2024
f7cfee4
linter errors
mpcarr Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mpf/devices/segment_display/segment_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,13 @@ def add_text_entry(self, text, color, flashing, flash_mask, transition, transiti
raise ValueError(f"Unknown update_method '{self.config['update_method']}' for segment display {self.name}")

# For the replace-text update method, skip the stack and write straight to the display
if flashing is None:
flashing = self._current_state.flashing
if flash_mask is None:
flash_mask = self._current_state.flash_mask
if not color:
color = self._current_state.text.get_colors()

new_text = TextTemplate(self.machine, text).evaluate({})
text = SegmentDisplayText.from_str(new_text, self.size, self.config['integrated_dots'],
self.config['integrated_commas'], self.config['use_dots_for_commas'],
Expand All @@ -171,7 +178,7 @@ def add_text(self, text: str, priority: int = 0, key: str = None) -> None:
def remove_text_by_key(self, key: Optional[str]):
"""Remove entry from text stack."""
if self.config['update_method'] != "stack":
self.info_log("Segment display 'remove' action is TBD.")
self.add_text("")
return

if key in self._text_stack:
Expand Down