Conversation
This changes from isDigit (only finds positive numbers) to casting to int to find all numbers. If an int is found, it converts it back to a string and strips the negative sign from it. It will then group as normal and replace the number portion with the grouped digits and leave the negative sign intact.
|
Not sure what the issue is here that failed, as it's a .C file that I did not touch. Also, I cannot run any of the tests on my local (Windows problems?) I didn't see where any of the tests were actually run in this build either. If the tests ran, great, if not, I would appreciate someone running them to make sure they all pass before merging. Thanks! Tied to this issue reporting on the MPF side: missionpinball/mpf#1683 |
|
The Windows cloud builds are broken currently. (Well, they were last time I checked a few months ago.) I was hoping a windows guru would figure out why, but no luck. (I'm a Mac user with a bit of Linux, I don't use Windows anymore.) I do have a Windows VM and I was able to get the builds to run fine locally, but they just randomly stopped working on GitHub. I'm going to look at the MPF installers again next week (specifically the MC installer, as MPF is fine), so I'll see if I can get them fixed and then merge this then. |
|
Thanks, Brian. And no rush on anything, saw someone reported the issue and was something I could fix. |
2 participants
This changes from isDigit (only finds positive numbers) to casting to int to find all numbers. If an int is found, it converts it back to a string and strips the negative sign from it. It will then group as normal and replace the number portion with the grouped digits and leave the negative sign intact.