Change sound_player and sound_loop_player volume behavior#333
Open
Change sound_player and sound_loop_player volume behavior#333
Conversation
volume setting in sound_player and sound_loop_player no longer overrides sound asset setting, but rather is multiplied by it.
Collaborator
|
@qcapen want to merge this? or is there anything missing? |
Collaborator
Author
|
I'd like to merge this, but it will alter all existing machine sound levels (essentially a breaking change, but worse because there are no errors). I also need to add the same behavior to the track player before merging. I do think this behavior should be preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
volume setting in sound_player and sound_loop_player no longer overrides sound asset setting, but rather is multiplied by it.