PR to further clean up show creator side of the toolbox.#2
Open
mpcarr wants to merge 13 commits intomissionpinball:mainfrom
Open
PR to further clean up show creator side of the toolbox.#2mpcarr wants to merge 13 commits intomissionpinball:mainfrom
mpcarr wants to merge 13 commits intomissionpinball:mainfrom
Conversation
bins to ipv4 localhost, adds socket chars boundary
Contributor
Author
|
@avanwinkle This PR goes back to May, I've been fixing a few things and have used these updates to create shows for a while without any issues. Do you think you will have chance to review and merge into main? I don't want my fork to become to divergent as I've started to work on the monitor side of the toolbox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the show scene in favour of using the playfield scene. The playfield scene is used to layout the lights, there doesn't seem a need to have multiple scenes setup for monitor and shows.
Uses the lights relative position within the GMC Playfield, this is inline with how the tag lights used in a show are currently worked out.
When rendering a show, instead of using a transparent window, this sets the playfield texture to black to ensure the alpha channel is always 1.