Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/absinthe_error_payload/changeset_parser.ex
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ defmodule AbsintheErrorPayload.ChangesetParser do
end

defp interpolated_value_to_string(value) when is_list(value), do: Enum.join(value, ",")
defp interpolated_value_to_string(value) when is_tuple(value), do: Enum.join(Tuple.to_list(value), "-")

defp interpolated_value_to_string({:parameterized, Ecto.Enum, %{on_load: mappings}}),
do: mappings |> Map.values() |> Enum.join(",")
Expand Down
18 changes: 18 additions & 0 deletions test/changeset_parser_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ defmodule AbsintheErrorPayload.ChangesetParserTest do
field(:virtual, :string, virtual: true)
field(:published_at, :naive_datetime)
field(:language, Ecto.Enum, values: [:en, :fr])
field(:metadata, {:array, :map})

belongs_to(:author, Author)
has_many(:tags, Tag)
Expand Down Expand Up @@ -182,6 +183,23 @@ defmodule AbsintheErrorPayload.ChangesetParserTest do
assert %ValidationMessage{code: :required, field: "tags.0.name", key: :name} = first
assert %ValidationMessage{code: :required, field: "tags.1.name", key: :name} = second
end

test "nested nil has many fields with errors" do
changeset =
%{"tags" => nil}
|> changeset()
|> cast_assoc(:tags,
with: fn tag, params ->
tag
|> cast(params, ~w(name)a)
|> validate_required(:name)
end
)

result = ChangesetParser.extract_messages(changeset)
assert [first] = result
assert %ValidationMessage{code: :association, field: :tags, key: :tags, message: "is invalid", options: [%{key: :type, value: "array-map"}]} = first
end
end

describe "construct_message/2" do
Expand Down