implement functions to comform with mirage.kv_ro interface#93
Open
PizieDust wants to merge 1 commit intomirage:mainfrom
Open
implement functions to comform with mirage.kv_ro interface#93PizieDust wants to merge 1 commit intomirage:mainfrom
PizieDust wants to merge 1 commit intomirage:mainfrom
Conversation
Member
|
Thanks. This looks very good. It seems a single space character was added at every line. I noticed #90 exists and is unmerged. I'll look into merging both. |
Author
I think this is due to running |
reynir
added a commit
to reynir/ocaml-fat
that referenced
this pull request
Jul 17, 2023
Github pull request mirage#93 with white space changes and rebased on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #91
The functions implemented here lacked two key implementations of get_partial and size required to be fully compliant with the mirage_kv interface.
This PR addresses that. Also, updating some functions, namely list and last_modified to align better with the signature definitions. With this update, the library builds correctly and also runs the test correctly
cc @reynir