Fix qcheck-alcotest dependency in irmin-test.opam#2393
Open
cuihtlauac wants to merge 2 commits intomirage:mainfrom
Open
Fix qcheck-alcotest dependency in irmin-test.opam#2393cuihtlauac wants to merge 2 commits intomirage:mainfrom
cuihtlauac wants to merge 2 commits intomirage:mainfrom
Conversation
Remove the `with-test` constraint from qcheck-alcotest dependency. The test/irmin/dune file declares a test that uses qcheck-alcotest as a library dependency. Since dune builds tests by default, this dependency is needed at build time, not just when running tests. Without this fix, `dune build` fails on a fresh opam switch because qcheck-alcotest is not installed (opam only installs `with-test` dependencies when using `--with-test`). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
samoht
reviewed
Jan 27, 2026
irmin-test.opam
Outdated
| "vector" {with-test & >= "1.0.0"} | ||
| "alcotest" {>= "1.7.0" & with-test} | ||
| "qcheck-alcotest" {>= "0.21.1" & with-test} | ||
| "qcheck-alcotest" {>= "0.21.1"} |
Member
There was a problem hiding this comment.
Do you really need a Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> attribution for this change?
Author
There was a problem hiding this comment.
Not sure. It did it in the first place.
2 tasks
zshipko
reviewed
Jan 27, 2026
Co-authored-by: zach <zachshipko@gmail.com>
Contributor
|
hm, i'm not sure why it's still using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with-testconstraint from qcheck-alcotest dependency in irmin-test.opamProblem
dune buildfails on a fresh opam switch with missingqcheck-alcotestpackage.The
test/irmin/dunefile declares a test that usesqcheck-alcotestas a library dependency. Since dune builds tests by default, this dependency is needed at build time, not just when running tests.The
with-testconstraint in opam means the dependency is only installed when usingopam install --with-test, but dune needs it for the default build.Test plan
opam install --deps-only .dune buildsucceeds🤖 Generated with Claude Code