Add CI job building irmin with dune package management#2388
Add CI job building irmin with dune package management#2388zshipko merged 3 commits intomirage:eiofrom
Conversation
|
Awesome, I am excited to use It's not clear what is going on with formatting when using opam packages but I will try to investigate |
CI is currently green without #2387 (for instance #2385) but it seems like there is a discrepancy between the formatting used when running the tests with dune and opam. I can spend a moment trying to figure out what's happening here today. |
|
The issue is that Maybe we need to require |
|
Yeah we already tried this but then the CI doesn't find a solution for the dependencies ( https://ocaml.ci.dev/github/mirage/irmin/commit/ed85a176f6637df008bbf8f9d9e655746436286b/variant/%28analysis%29 ) |
|
The problem seems to be |
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
a87ab81 to
fd2132a
Compare
|
Thanks Zach for merging this :) |
Hello irmin folks!
We've been wanting to make sure that irmin can be built using dune package management, and this PR introduces a CI job that can make that check automatically.
If you were to try building irmin with 'stock' dune (3.20.2) with pkg enabled, you'd hit a error related to
irmin-watcher.Since ocaml/dune#13232, this is now fixed, and dune (on its
mainbranch) can be used by irmin devs as a daily driver!Note that this PR is built on top of #2387