Speed up Store.last-modified by comparing hashes instead of file contents#2335
Open
zazedd wants to merge 3 commits intomirage:mainfrom
Open
Speed up Store.last-modified by comparing hashes instead of file contents#2335zazedd wants to merge 3 commits intomirage:mainfrom
Store.last-modified by comparing hashes instead of file contents#2335zazedd wants to merge 3 commits intomirage:mainfrom
Conversation
art-w
force-pushed
the
last-modified-perf
branch
from
3239903 to
b908da8
Compare
art-w
requested changes
Sep 19, 2024
Contributor
art-w
left a comment
art-w
left a comment
There was a problem hiding this comment.
Thanks, this provides a huge speedup for large values!
Looking at the overall algorithm used by last_modified, I believe there could be complexity explosion with fork/merge: it doesn't detect that a commit was already checked when reached from another path? I wonder if you have some ideas on how to fix this also :)
art-w
force-pushed
the
last-modified-perf
branch
from
b908da8 to
e61a347
Compare
clecat
approved these changes
Sep 30, 2024
Contributor
clecat
left a comment
clecat
left a comment
There was a problem hiding this comment.
LGTM, thx a lot for the work
There might be a small issue however, when a commit is older than it's parent, the function might missbehave.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the
Store.last_modifiedfunction to compare the precomputed file hashes instead of their contents, as the latter is significantly (~10 to 20x) slower. :)(More specifically,
Tree.findis way slower thanTree.find_tree)It also changes the documentation of the function where variable
nis wrongly referred to asnumber.