Open
Conversation
icristescu
force-pushed
the
test_log_file_2
branch
from
0f11f1c to
4d6b317
Compare
Ngoguey42
reviewed
Oct 12, 2021
Ngoguey42
left a comment
Ngoguey42
left a comment
There was a problem hiding this comment.
Since the signature of log_file.ml is private to index, could you make all the hook parameters non-optional in order to allocate less?
I'm not sure this affects a lot the performances, but this is the kind of optimisation that we have already cared about in other places.
icristescu
force-pushed
the
test_log_file_2
branch
from
4d6b317 to
7227925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit late for #358 but in case we want to add it, here is a test that exposes that bug.