Skip to content

Conversation

@okjodom
Copy link
Contributor

@okjodom okjodom commented Aug 18, 2025

The fmcd API now provides:

  • Automatic invoice monitoring - Using fedimint's native subscribe_ln_receive
  • Real-time streaming updates - SSE endpoints for live invoice status
  • Bulk status queries - Efficient multi-invoice management
  • Full fedimint 0.8 alignment - Native behavior matching the underlying client

Copilot AI review requested due to automatic review settings August 18, 2025 20:34

This comment was marked as outdated.

The fmcd API now provides:
  - Automatic invoice monitoring - Using fedimint's native subscribe_ln_receive
  - Real-time streaming updates - SSE endpoints for live invoice status
  - Bulk status queries - Efficient multi-invoice management
  - Full fedimint 0.8 alignment - Native behavior matching the underlying client

feat: simplify fmcd api surface
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes fmcd to align with fedimint-client 0.8 behavior, introducing automatic invoice monitoring, real-time streaming, and bulk operations while removing deprecated external pubkey APIs.

  • Replaces manual invoice polling with automatic fedimint native monitoring using subscribe_ln_receive
  • Adds real-time SSE endpoints for live invoice status streaming and bulk operations
  • Removes deprecated external pubkey tweaked APIs and await methods

Reviewed Changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/webhooks/invoice.rs New webhook notification system for invoice events with exponential backoff
src/router/handlers/ln/invoice.rs Enhanced invoice creation with automatic monitoring and unified status tracking
src/router/handlers/ln/status.rs New unified status endpoints supporting bulk queries and operation ID lookup
src/router/handlers/ln/stream.rs SSE streaming endpoints for real-time invoice monitoring and global events
src/router/ws.rs Updated WebSocket routing to use new status endpoints and correlation tracking
src/main.rs Updated REST API routes to align with fedimint 0.8 endpoint structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@okjodom okjodom merged commit 633a08c into main Aug 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant