Remove profile dependency from implementation code generation#15
Open
Remove profile dependency from implementation code generation#15
Conversation
minhaj10p
force-pushed
the
impl-excel-param
branch
2 times, most recently
from
c9fdbef to
4c2d25d
Compare
mohuk
reviewed
Feb 4, 2019
impl/impl_test.go
Outdated
|
|
||
| "github.com/docker/oscalkit/types/oscal/catalog" | ||
| "github.com/docker/oscalkit/types/oscal/profile" | ||
| "github.com/davecgh/go-spew/spew" |
There was a problem hiding this comment.
Do we really need spew as a dependency to oscalkit ?
asadullah-yousuf-10p
requested changes
Feb 4, 2019
Collaborator
asadullah-yousuf-10p
left a comment
asadullah-yousuf-10p
left a comment
There was a problem hiding this comment.
See my comments
impl/implementsprofile.go
Outdated
| } | ||
| return s | ||
| } | ||
| func fetchParameter(s string) (string, string) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| func fetchParameter(s string) (string, string) { | |
| func parseCheckAndValue(checkAndValue string) (string, string) { |
minhaj10p
force-pushed
the
impl-excel-param
branch
from
4c2d25d to
98f2d4a
Compare
asadullah-yousuf-10p
requested changes
Feb 4, 2019
Collaborator
asadullah-yousuf-10p
left a comment
asadullah-yousuf-10p
left a comment
There was a problem hiding this comment.
Just a few more changes.
minhaj10p
force-pushed
the
impl-excel-param
branch
from
98f2d4a to
3cbbda4
Compare
Collaborator
|
LGTM |
minhaj10p
force-pushed
the
impl-excel-param
branch
from
4e5623b to
248f581
Compare
minhaj10p
force-pushed
the
impl-excel-param
branch
from
248f581 to
b49646f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.