Security review of deepcopy out support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ming-Wei Shih <mishih@microsoft.com>
mingweishih
commented
Nov 24, 2020
| pargs_out->n[_i_1].array_of_int = NULL; | ||
| if (_rhs[_i_1].array_of_int) | ||
| { | ||
| int* _l_1_array_of_int = |
Owner
Author
There was a problem hiding this comment.
Own comment: use local variable to prevent the host from manipulating the memory used by the memcpy below. Note that the oe_host_malloc ensures that the return buffer resides on the host.
mingweishih
commented
Nov 24, 2020
| _rhs[_i_1].array_of_int, | ||
| ((size_t)4 * sizeof(int))); | ||
| } | ||
| CountStruct* _l_1_array_of_struct = NULL; |
mingweishih
commented
Nov 24, 2020
| _l_1_array_of_struct[_i_2].ptr = NULL; | ||
| if (_rhs[_i_1].array_of_struct[_i_2].ptr) | ||
| { | ||
| uint64_t* _l_2_ptr = (uint64_t*)oe_host_malloc( |
mingweishih
commented
Nov 24, 2020
| { | ||
| int* _l_1_array_of_int = | ||
| (int*)oe_host_malloc(((size_t)4 * sizeof(int))); | ||
| pargs_out->n[_i_1].array_of_int = _l_1_array_of_int; |
Owner
Author
There was a problem hiding this comment.
pargs_out->n[_i_1].array_of_int is under control by the host, but we won't use it directly other than this assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ming-Wei Shih mishih@microsoft.com