Add __strlcpy_chk symbol for Minecraft 1.21.130.3+ compatibility #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added __strlcpy_chk function to handle string copy with size checks.
ChristopherHX
approved these changes
Dec 30, 2025
Member
ChristopherHX
left a comment
ChristopherHX
left a comment
There was a problem hiding this comment.
Thank you, looks good to me
Contributor
Author
Thanks! I’m glad I could help fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minecraft 1.21.130.3 uses libPlayFabMultiplayer.so which requires the __strlcpy_chk symbol from Bionic libc. Without it, the game fails to load:
dlopenfailed: cannot locate symbol "__strlcpy_chk"This PR adds the missing implementation following the same pattern as other fortified functions (__memcpy_chk, __strcpy_chk , etc.).
Changes:
common.h : Added function declaration
common.cpp : Added implementation with bounds checking, registered in
add_string_shimmed_symbols
Tested with: Minecraft 1.21.130.3, 1.21.144, 1.21.131
((((Very important remove the libmcpelauncher-updates.so))))