Added power limit related methods#6
Open
aleksandrov wants to merge 4 commits intomindprince:masterfrom
Open
Conversation
aleksandrov
commented
Mar 31, 2018
aleksandrov
commented
- PowerLimit()
- PowerLimitConstraints()
- SetPowerLimit()
rohitagarwal003
requested changes
May 14, 2018
Member
rohitagarwal003
left a comment
rohitagarwal003
left a comment
There was a problem hiding this comment.
Thanks for the PR @aleksandrov.
Sorry for the late review. Just got around to taking a look at this.
| } | ||
|
|
||
| // Set new power limit of this device. | ||
| func (d Device) SetPowerLimit(pl uint) error { |
Member
There was a problem hiding this comment.
Can you remove this method? I would like to keep this library to only read things and not change anything.
Author
There was a problem hiding this comment.
@mindprince Sorry for even late comments :-) Why you do not want to have altering state functionality?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.