MOBILE-72: Refactor HTTP response handling to prioritize HTTP status code#692
Open
MOBILE-72: Refactor HTTP response handling to prioritize HTTP status code#692
Conversation
added 3 commits
April 2, 2026 14:40
…code HTTP code is now the primary discriminator. Body status is only validated within the context of the HTTP code category. Fixes: 4xx + status "Success" no longer treated as success.
12 test cases covering all key scenarios from the API spec: 2xx/4xx/5xx with various body statuses, needBaseResponse=false, emptyData=true, 404 special case, 3xx redirect handling.
…ault parameter for needBaseResponse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://tracker.yandex.ru/MOBILE-72
Summary
Refactor network response handling to prioritize HTTP status code over body status field, preventing cases where 4xx/5xx responses with "Success" in body were incorrectly treated as successful.
Type of Change
Changes
handleResponseinMBNetworkFetcherinto smaller focused methods:makeResponseContext,handleResponseData, and per-status-code-group handlersneedBaseResponse=trueviaNetworkFetcherprotocol extension to simplify call sitesMBEventRepositorycall by using the new default parameterTesting