Skip to content

Conversation

@paquiteau
Copy link
Member

  • Closes None

Changes proposed in this pull request:

  • Add Support for autograd wrapping off-resonance operators
  • Fixed bug for array conversion with dict arguments.

Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems to have very less changes than i assumed? Do things work straight Outta the box?

Is the autodiff of library approximation actually close to autodiff of complete off resonance operation? (Note how autodiff of NUFFT was not matching autodiff of ndft perfectly).

Or is the PR still not ready for review?

Tests and example can help!
A great example is trying to learn off resonance map from a decent initialisation with parameterization of maps by splines. WDYT?

@paquiteau
Copy link
Member Author

Yes it's that simple to make it happen :)

Adding tests could be done, but I am also working/testing it in downstream application. However learning the field-map directly is a badly conditioned problem, and it also depends on the image/data itself in a intricated manner. I don't think we want to support this directly in mri-nufft (at least for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants