2.x - Add support for RXJava 2.0 #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports the library and example app to 2.0. Some semantics changed because emitting nulls is not supported in 2.0, in these cases, the Observable now emits a dummy boolean.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage 98.97% 98.97%
- Complexity 0 66 +66
=========================================
Files 25 25
Lines 195 195
=========================================
Hits 193 193
Misses 2 2
Continue to review full report at Codecov.
|
Collaborator
|
Thanks for this. I will take a look at the weekend and give feedback/merge. Also sorry for the delay. |
|
hi, developer, is this still under developing/ maintain? |
Collaborator
|
@defer would you be interested in taking ownership of this lib? I don't have the tie to maintain and I think it can be useful for others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an abi-breaking change. The behavior is the same with the exception of methods that used to return Observable now return Observable because null emissions are not supported anymore.
As for compatibility, most projects supporting both 1.x and 2.x are keeping separate branches and keeping separate package names.This patchset does not change the package name, but it may go in that direction in the future.