Feat: Modernize PyTune - PyQt5 migration, Python 3 compatibility, and real-time playback features#2
Open
anubhuti24 wants to merge 2 commits intomilanboers:masterfrom
Open
Conversation
…n pytune modules. Introduced playback features and improved UI components for better user interaction.
… usage instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR modernizes the PyTune project by migrating from deprecated PyQt4 to PyQt5, updating all dependencies to Python 3.11.7 compatible versions, and adding significant new features including real-time audio playback with chord detection.
🎯 Key Changes
1. Dependency Updates & Modernization
requirements.txtwith pinned dependency versions2. Python 3 Compatibility Fixes
Cython Module Updates (
pytune/*.pyx)pytune.prefix for proper module resolutionimport functions→import pytune.functionsimport notefinder→import pytune.notefinderzip()usage to return lists explicitlyzip(freqsl, weight)→list(zip(freqsl, weight))Wave File Handling (
pytune/wave2.pyx)getFromFile()function for Python 3 compatibility:str filenametype hintswave.readframes()(now returns bytes in Python 3)FileNotFoundErrorandValueError'r'to'rb'for binary reading3. Main Application Enhancements (
chordfinder.py)PyQt5 Migration
QFileDialog.getOpenFileName()to return tuple (PyQt5 behavior)New Features
🎵 Real-time Audio Playback
QMediaPlayerfor WAV file playback📊 Automatic Song Analysis
🎨 Enhanced UI Components
🔧 Code Quality Improvements
4. Documentation & Project Files
README.mdwith:.gitignorefor Python projects:__pycache__/,*.pyc,*.so,*.cfiles📊 Statistics
chordfinder.py: +432 lines (new features and PyQt5 migration)pytune/wave2.pyx: +123 lines (complete rewrite for Python 3)README.md: +102 lines (new documentation).gitignore: +138 lines (new file)🧪 Testing
📝 Migration Notes
For Users Upgrading:
requirements.txtpython setup.py build_ext --inplaceBreaking Changes:
🎉 Benefits
🔗 Related Issues