Fix keyboard layout regression for non-QWERTY layouts #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255 #264
Problem
The keyboard layout regression introduced in v1.17.0 broke support for non-QWERTY layouts (AZERTY, Colemak, Dvorak, etc.). The new KeyMaps system was always using hardcoded US-QWERTY mapping, ignoring the user's actual keyboard layout.
Root Cause
Controller.charForEvent()unconditionally usedKeyMapslookup instead of respectingevent.charactersIgnoringModifiersSolution
event.charactersIgnoringModifiersfor printable charactersChanges
charForEvent()method to branch onforceEnglishKeyboardLayoutsettingenglishGlyph()method for force English modeTesting
Impact