Add basic support without steam_api + NDEBUG small fix#2042
Open
q4a wants to merge 4 commits intomiki151:masterfrom
Open
Add basic support without steam_api + NDEBUG small fix#2042q4a wants to merge 4 commits intomiki151:masterfrom
q4a wants to merge 4 commits intomiki151:masterfrom
Conversation
code from https://github.com/miki151/keeperrl/blob/f0d2a78a6ad7c2632be6d8554e4d947f980648ae/fx_base.h#L30 #define PARANOID_CHECKS //... #if defined(PARANOID_CHECKS) && !defined(NDEBUG) #define PASSERT CHECK #else #define PASSERT(...) #endif When NDEBUG defined game will just ignoring all PASSERT(...), and PASSERT(size.x >= 0 && size.y >= 0) << size.x << " " << size.y; will become just : << size.x << " " << size.y;
|
Similarly to #ifndef USE_STEAMWORKS
#include "steam_achievements.h"
#include "achievement_id.h"
SteamAchievements::SteamAchievements() {
}
void SteamAchievements::achieve(AchievementId id) {
}
#endif // USE_STEAMWORKS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic support without steam_api - fixes #1990
Also small fix for NDEBUG in last commit