Bug Hunt addressing #1592 #1640 #1650 #1655 #1646#1648
Open
sandipratamaputra wants to merge 9 commits intomiki151:stablefrom
Open
Bug Hunt addressing #1592 #1640 #1650 #1655 #1646#1648sandipratamaputra wants to merge 9 commits intomiki151:stablefrom
sandipratamaputra wants to merge 9 commits intomiki151:stablefrom
Conversation
Change pathing behaviour for the furniture HIDDEN_CASTLE_DOOR, it now forbid pathing, unless forced by walking through it in direct control mode. Fix addressed for miki151#1592
it now says "Build to go down in the z-levels." instead "Build to pass over water of lava."
sandipratamaputra
changed the title
Death of Evil God Adoxie has been changed to "Evil God Adoxie is put into slumber by *creature.name" added this new string after that: "Evil God Adoxie has been vanquished. May he never rise again."
sandipratamaputra
changed the title
If creature name is identical to wha killed it show it has committed suicide instead of "A slayer of A killed by A slayer of A."
sandipratamaputra
changed the title
so players notice locking mechanism. Need new viewID called key_semi_highlight. Addressing miki151#1646
sandipratamaputra
changed the title
To support future graphical changes (including mod). It is now using separated viewId from other locking mechanism like doors for example.
Related issue: miki151#1646 Equipment lock now has 4 states (supposedly).
Instead of displaying the same tooltip for both making players think that they're locked, while it isn't. Since now it also shows unlocked symbol, in case they can't differentiate it.
prostolyubo
reviewed
Jan 28, 2021
| 1900 HOSTILE_DIG | ||
| 2000 HOSTILE_DIG_NO_SKILL | ||
| } | ||
| #destroyFX = { ROCK_CLOUD Rgb 200 200 200 255 } |
There was a problem hiding this comment.
Remove redundant comments
Suggested change
| #destroyFX = { ROCK_CLOUD Rgb 200 200 200 255 } |
prostolyubo
reviewed
Jan 28, 2021
| 2000 HOSTILE_DIG_NO_SKILL | ||
| } | ||
| #destroyFX = { ROCK_CLOUD Rgb 200 200 200 255 } | ||
| #tryDestroyFX = { DESTROY_FURNITURE Rgb 200 200 200 255 } |
There was a problem hiding this comment.
Remove redundant comments
Suggested change
| #tryDestroyFX = { DESTROY_FURNITURE Rgb 200 200 200 255 } |
prostolyubo
suggested changes
Jan 28, 2021
Comment on lines
+3217
to
+3221
| WL(viewObject, ViewId("gui_inventory_locked")) : | ||
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_inventory_locked_highlighted")): | ||
| !items[i].locked ? | ||
| WL(viewObject, ViewId("gui_inventory_unlocked")) : | ||
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_inventory_unlocked_highlighted"))), |
There was a problem hiding this comment.
IDs are not matching the entries from data_free/game_config/tiles.txt
Suggested change
| WL(viewObject, ViewId("gui_inventory_locked")) : | |
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_inventory_locked_highlighted")): | |
| !items[i].locked ? | |
| WL(viewObject, ViewId("gui_inventory_unlocked")) : | |
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_inventory_unlocked_highlighted"))), | |
| WL(viewObject, ViewId("gui_equipment_locked")) : | |
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_equipment_locked_highlighted")): | |
| !items[i].locked ? | |
| WL(viewObject, ViewId("gui_equipment_unlocked")) : | |
| WL(mouseHighlight2, WL(viewObject, ViewId("gui_equipment_unlocked_highlighted"))), |
| msg = c->getName().the() + " has committed suicide."; | ||
| else | ||
| msg = c->getName().the() + " is "+ | ||
| c->getAttributes().getDeathDescription() + " by " + param; break; |
There was a problem hiding this comment.
unindent
Suggested change
| c->getAttributes().getDeathDescription() + " by " + param; break; | |
| c->getAttributes().getDeathDescription() + " by " + param; break; |
| if ((c->getName().the())compare(param) = 0) | ||
| // If creature name compared to what killed it, | ||
| // has zero difference, perform the code below. | ||
| msg = c->getName().the() + " has committed suicide."; |
There was a problem hiding this comment.
Consider restoring the cause of death, for instance:
Suggested change
| msg = c->getName().the() + " has committed suicide."; | |
| msg = c->getName().the() + " has committed suicide (" + c->getAttributes().getDeathDescription() + ")."; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about multiple pull requests, I'm still learning how to use gitHub.
Issue 1: Changed pathing behaviour for the furniture HIDDEN_CASTLE_DOOR,
it now forbids pathing, unless forced by walking through it in direct control mode.
Fix addressed for #1592
Issue 2: Changed furniture desc. for down stairs
Fix addressed for #1640
Issue 3: Changed death message for Evil God Adoxie
Fix addressed for #1650
Issue 4: An attempt to fix death message by suicide.
Fix addressed for #1655
Issue 5: Make equipment locking mechanism a bit visible, to help new players.
Fix addressed for #1646