Various typescript fixes, updated all dependencies, package.json cleanup #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information see: chalk/chalk#228 (comment)
src/spec/spec.ts:24:5 - error TS2322: Type 'Promise<Object>' is not assignable to type 'Promise<ApiSpec>'.
Type 'Object' is not assignable to type 'ApiSpec'.
The 'Object' type is assignable to very few other types. Did you mean to use the 'any' type instead?
Property 'host' is missing in type 'Object'
You could now easily test the client with: yarn client
Owner
|
@jpoppe Thanks for these updates. On vacation 🌴 at the moment but will take a look in a week or so when I'm back. On surface all looks good 👍 |
Author
Don't hurry ;), enjoy your holiday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues getting this package to compile, got various Typescript errors, etc., probably because I use a recent Node version.
In those commits I have updated all dependencies, fixed the Typescript errors to make it run and added a client command to package.json so you could run the client with ts-node with: yarn run client