Skip to content

Add build workflow#3

Merged
mikeleg merged 17 commits intomikeleg:mainfrom
davide-pi:feature/add-build-workflow
May 12, 2025
Merged

Add build workflow#3
mikeleg merged 17 commits intomikeleg:mainfrom
davide-pi:feature/add-build-workflow

Conversation

@davide-pi
Copy link
Collaborator

@davide-pi davide-pi commented May 12, 2025

Add build workflow

Wrokflow steps:

  1. npm i
  2. npm run build

Add badge in readme

Add trigger on tags push

Tags must have the pattern \d+.\d+.\d+

@mikeleg mikeleg requested a review from Copilot May 12, 2025 08:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new build workflow along with GitVersion configuration and a build badge to the README.

  • Added build workflow in .github/workflows/build.yml with steps for version determination, build, and publishing to NPM.
  • Introduced GitVersion configuration in GitVersion.yml to manage semantic versioning based on branch types.
  • Updated README.md to include a badge for the build status.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
README.md Added a build status badge linked to the build workflow.
GitVersion.yml Configured versioning strategy for branch types and tags.
.github/workflows/build.yml Defined build workflow steps with triggers on branch and tag push.

GitVersion.yml Outdated
main:
label: beta
increment: Minor
regex: ^main?
Copy link

Copilot AI May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex pattern '^main?' might inadvertently match 'mai' due to the optional 'n'. If only the exact 'main' branch should match, consider using '^main$' instead.

Suggested change
regex: ^main?
regex: ^main$

Copilot uses AI. Check for mistakes.
@mikeleg mikeleg merged commit 68c019a into mikeleg:main May 12, 2025
1 check passed
@davide-pi davide-pi deleted the feature/add-build-workflow branch May 21, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants