Fix bug where unable to change default on enum properties

[pljakobs]

fixed a bug in dbgen.py, where a default value was checked against an enum after the value had been converted to an index into the enum as documented in #70

I feel that the 2nd check is redundant as the default has already been verified against the enum and the index was successfully calulated, therefore I believe it can be just removed.

[pljakobs]

I'm a little unsure about the itemtype naming fix - it seems to build, but I'm not 100% of the wider implications that this may have.
In essence, for all enum fields, I now define {fieldname}ItemType which removes the duplicate definitions.

[pljakobs]

okay, my uncertainty was justified, the test build fails with the itemtypes not found, so there's another point where this needs to be adapted.

[pljakobs]

looking at the test module:

		auto& colorType = Root::Colors::itemtype;
		auto& quotientType = Root::Quotients::itemtype;
		auto& smallMapType = Root::SmallMap::itemtype;
		auto& numberMapType = Root::NumberMap::itemtype;

those itemtypes are now called colorItemType, quotientsItemType etc - not sure if that's actually a good way to address the issue.

[pljakobs]

I am a bit unsure now, with my changes, my firware builds without issues, only this explicit access to itemType in the test fails - not sure what is the relevance.

[mikee47]

Thanks for this fix. Can you restrict this to just the 'defaults and enums' and we'll look at the itemtype naming separately.

[pljakobs]

new push with just 0cfd545

[mikee47]

Thanks. Amended test schema to ensure this gets covered.

[mikee47]

Thanks for fixing this bug! Note for next time: Remember to create a new branch e.g. fix/enum-bug rather than working on develop directly.