Add streaming export options #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows `pretty` to be configured on a per-stream basis.
Include support for output options at database level
Owner
Author
|
@pljakobs I'd welcome your thoughts on this reworking of the export options. I've removed the ability to override the object name and emit raw content as there's currently no use case for them. |
slaff
pushed a commit
to SmingHub/Sming
that referenced
this pull request
Feb 12, 2025
Fix handling of `name=value` selectors for root arrays [#64](mikee47/ConfigDB#64) Support conversion of named selector into range [#65](mikee47/ConfigDB#65) * Allows item deletion using `"x[name=object 1]": []` syntax Add `ExportOptions` [#68](mikee47/ConfigDB#68) Allows `pretty` to be configured on a per-stream basis. Add optional `useName`, `asObject` flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #60 to enable variations in how JSON is generated.
An extensible
ExportOptionsstructure has been added to allcreateExportStreamandexportToStreammethods to allow customisation of output. It contains three flags:pretty
This replaces the global
Json::format.prettyflag to allow control on a per-stream basis.useName
Set this flag to include the object name in the output. For example:
Default behaviour excludes the name:
This also works for the database using the name defined in the schema.
asObject
Outputs the entire object definition:
{ "int_array": [13,28,39,40] }The
useNameflag is implicit in this option and does not need to be set as well.NB. I decided against using an enum to try and simplify the interface.