Merge staging into main #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he documentation for the `acura` service and the overall project overview in the root README.md. This work is based on a detailed analysis of the `acura` and `ui` services to provide you with accurate and specific functional descriptions.
Here's what changed:
1. **Root `README.md` Enhancement:**
* I've rewritten the "Overview" section to provide in-depth descriptions of each major component (`acura`, `ui`, `migrations`, `migrator`).
* It now details the specific roles, key functionalities, and core technologies of the `acura` curation engine (asynchronous processing, AI/LLM usage, vector search, external API integrations) and the `ui` Next.js application (BFF architecture, custom auth, direct DB access, RabbitMQ messaging for proactive curation).
2. **`acura/README.md` Overhaul:**
* I've completely updated the existing README for the `acura` service.
* It now includes a detailed explanation of Acura's core functionality, its event-driven architecture (RabbitMQ), the multi-stage `MusicDiscoveryPipeline`, and interactions with PostgreSQL (pgvector), OpenAI, Spotify, and Brave Search.
* It also provides an overview of key Python modules within the `acura` service.
* I've listed accurate requirements and a comprehensive set of environment variables with examples.
* Updated development setup and running instructions using `uv` are now included.
* Details on containerization for deployment have been added.
This work addresses your feedback for more detailed and less ambiguous service descriptions. I've also completed a deep dive into the `ui` service, and its dedicated README (`ui/README.md`) will be updated in a subsequent session.
…fk.sql Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Docs deep dive part1
- Created a new docker-compose.yml file to define services for PostgreSQL, RabbitMQ, and PgAdmin. - Configured PostgreSQL with default user, password, and database. - Set up RabbitMQ with default credentials and management UI. - Added PgAdmin for database management, dependent on PostgreSQL. - Removed obsolete engineq.code-workspace file. - Deleted example environment configuration file from the migrator directory.
- Added a comprehensive .dockerignore file to exclude unnecessary files from Docker builds. - Introduced a .python-version file to specify Python version 3.11. - Removed outdated .vscode/launch.json and Dockerfile, replacing them with a new dockerfile for UV. - Updated internal agent initialization to use OpenAIProvider for better configuration management. - Modified Spotify service to improve playlist retrieval logic and error handling. - Enhanced SQLAlchemy models with new relationships and constraints. - Refactored DAO methods to improve type hints and error handling. - Added Justfile for managing development tasks and ensuring dbmate installation. - Updated pyproject.toml to include Just as a development dependency. - Removed obsolete scripts for model generation and dbmate CLI execution. - Updated docker-compose.yml to use pgvector/pgvector for PostgreSQL service. - Created a new Dockerfile for the UI service using Node.js.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 17569444 | Triggered | Generic Password | 9cb2824 | docker/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.