Conversation
|
This PR would apply to a hypothetical 5.3 branch and is mainly targeted at people looking for a functioning version of MigLayout for JDK 8 |
|
@mikaelgrev do you want to take a peek at these commits? Not sure if we should merge these in master or a separate branch. JDK 8 is, ahm, old. |
|
I've looked at them, @tbee, and sure the Exception protection seems fine. But I don't really understand the revert to v4.2 defaults. Are the current ones wrong because of some DPI fix or similar? Also, don't really understand the purpose of the other patches, of which there are eight? Though I must admit that I'm not really used to Open Source PR handling, so it might just be that. Do as you think is best with them. |
|
I agree that 8 is very old, and I'm not suggesting this should go into main. This PR is just for folks who want to upgrade 4.2 -> 5.3 without breakage. |
|
@mikaelgrev as for the platform defaults: In #43 there's people who see the new defaults break layouts. I saw the same thing. I guess it depends on your definition of "wrong". Is it wrong to change defaults in miglayout (breaking layouts), or is it wrong to have miglayout's defaults deviate from the platform. I'll leave that up to you. :) |
patch 1 restores v4.2 platform defaults
patch 2 restores v4.2 catching of exceptions in getBaseline for swing (since the previous fix of passing at least 0 is insufficiënt: e.g. javax.swing.plaf.basic.BasicComboBoxUI#getBaseline will happily decrement the 0 we pass it)