392-odometer-liquid-glass#405
Merged
mikaelacaron merged 10 commits intomikaelacaron:devfrom Feb 12, 2026
Merged
Conversation
Owner
|
Thanks for submitting this! I'll review it soon! |
mikaelacaron
approved these changes
Feb 12, 2026
Owner
mikaelacaron
left a comment
mikaelacaron
left a comment
There was a problem hiding this comment.
Great work!! Thank you for your patience and for contributing! ❤️
I wasn’t a big fan of the custom sections, because they’re not really “Liquid Glass” but custom shadows. I do love the icons you’ve added!
On AddOdometerReadingView / EditOdometerReadingView, the updates are making the toolbar buttons into icons, and OdometerRowView, I like the icons
| if viewModel.readings.isEmpty { | ||
| Text("Add your first odometer", | ||
| comment: "Placeholder text for empty odometer reading list") | ||
| ContentUnavailableView { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it Does
This PR implements the "Liquid Glass" design language across the Odometer feature, modernizing the UI with translucent, frosted-glass aesthetics while ensuring compatibility with system accessibility and dark mode settings.
How I Tested
Screenshot