Skip to content

Comments

Feat: add small total maintenance events count widget#394

Merged
mikaelacaron merged 17 commits intomikaelacaron:devfrom
TMaszko:15-add-small-maintenance-events-count-widget
Oct 12, 2025
Merged

Feat: add small total maintenance events count widget#394
mikaelacaron merged 17 commits intomikaelacaron:devfrom
TMaszko:15-add-small-maintenance-events-count-widget

Conversation

@TMaszko
Copy link
Contributor

@TMaszko TMaszko commented Oct 9, 2025

What it Does

How I Tested

  • Run the Widget schema
  • Add a new vehicle in the main app
  • Check the Home Screen -> Now widget will look like so:
Screenshot 2025-10-09 at 23 29 20
  • Long press the widget and select the vehicle
image
  • Select a vehicle
image
  • In case of no events you will see something like this:
image
  • In case of any events:
image
  • In case of an unexpected error:
Screenshot 2025-10-10 at 00 08 56

Notes

  • Cross sharing Firebase authentication here
  • Kudos to aking618 for a great work that this PR is heavily inspired by.
  • Designs are not final ;) I couldn't quickly find any better solution though :D
  • This is my first PR in Swift so please keep that in mind ;)

Screenshot

Screenshot from the widget gallery
image

@TMaszko TMaszko requested a review from mikaelacaron as a code owner October 9, 2025 22:10
@TMaszko TMaszko changed the title feat: add small total maintenance events count widget [15] feat: add small total maintenance events count widget Oct 10, 2025
It wasn't properly using the xcconfig file for the development team
because this line is fine being that long
it's removing the empty string because it resolves to use the xcconfig file
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! Main thing to change is the DataService to use async throws, rather than the Result type

I've also updated various comments / line breaks here and there, so be sure to pull changes, and then make the last change that I noted! Thank you, then I'll re-review

If you have any questions, you can comment directly on that thread, otherwise click the resolve button once you've addressed my comment. Once you fix everything, please click the re-review button!

Image

Comment on lines 5 to 6
<key>KeychainAccessGroup</key>
<string>$(AppIdentifierPrefix)com.mycompany.Basic-Car-Maintenance.Shared</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks hard coded, and instead we'd need a way to properly use the xcconfig file, using the bundle ID, PRODUCT_BUNDLE_IDENTIFIER because it should be unique for each person who's contributed to the project

If you're not sure how to fix this, drop a comment and I can do it before merging this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a pure config stuff ;) I'll leave it for you

<true/>
<key>keychain-access-groups</key>
<array>
<string>$(AppIdentifierPrefix)com.mycompany.Basic-Car-Maintenance.Shared</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same this this using the xcconfig file

<dict>
<key>keychain-access-groups</key>
<array>
<string>$(AppIdentifierPrefix)com.mycompany.Basic-Car-Maintenance.Shared</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here about the xcconfig file

@mikaelacaron mikaelacaron changed the title [15] feat: add small total maintenance events count widget Feat: add small total maintenance events count widget Oct 10, 2025
@TMaszko TMaszko requested a review from mikaelacaron October 11, 2025 19:42
Which fixes a SwiftLint warning
Not really sure if this works, we'll see
Which I dont' think was needed, we'll see
Copy link
Owner

@mikaelacaron mikaelacaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 👏 thank you!!

It wasn't showing the widget when I was signed in anonymously, but I'll Sign in with Apple and see if that changes, but otherwise that's totally fine! We can always fix that later if needed

@mikaelacaron mikaelacaron merged commit 6b5b30b into mikaelacaron:dev Oct 12, 2025
1 of 2 checks passed
@TMaszko TMaszko deleted the 15-add-small-maintenance-events-count-widget branch October 12, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEATURE - Small Widget, View Maintenance Events

2 participants