Feat: add small total maintenance events count widget#394
Conversation
It wasn't properly using the xcconfig file for the development team
because this line is fine being that long
it's removing the empty string because it resolves to use the xcconfig file
mikaelacaron
left a comment
There was a problem hiding this comment.
Great work!! Main thing to change is the DataService to use async throws, rather than the Result type
I've also updated various comments / line breaks here and there, so be sure to pull changes, and then make the last change that I noted! Thank you, then I'll re-review
If you have any questions, you can comment directly on that thread, otherwise click the resolve button once you've addressed my comment. Once you fix everything, please click the re-review button!
Basic-Car-Maintenance/Shared/Settings/ViewModels/AuthenticationViewModel.swift
Outdated
Show resolved
Hide resolved
| <key>KeychainAccessGroup</key> | ||
| <string>$(AppIdentifierPrefix)com.mycompany.Basic-Car-Maintenance.Shared</string> |
There was a problem hiding this comment.
This looks hard coded, and instead we'd need a way to properly use the xcconfig file, using the bundle ID, PRODUCT_BUNDLE_IDENTIFIER because it should be unique for each person who's contributed to the project
If you're not sure how to fix this, drop a comment and I can do it before merging this
There was a problem hiding this comment.
Since it's a pure config stuff ;) I'll leave it for you
| <true/> | ||
| <key>keychain-access-groups</key> | ||
| <array> | ||
| <string>$(AppIdentifierPrefix)com.mycompany.Basic-Car-Maintenance.Shared</string> |
There was a problem hiding this comment.
same this this using the xcconfig file
| <dict> | ||
| <key>keychain-access-groups</key> | ||
| <array> | ||
| <string>$(AppIdentifierPrefix)com.mycompany.Basic-Car-Maintenance.Shared</string> |
There was a problem hiding this comment.
same here about the xcconfig file
Which fixes a SwiftLint warning
Not really sure if this works, we'll see
Which I dont' think was needed, we'll see
mikaelacaron
left a comment
There was a problem hiding this comment.
Great work!! 👏 thank you!!
It wasn't showing the widget when I was signed in anonymously, but I'll Sign in with Apple and see if that changes, but otherwise that's totally fine! We can always fix that later if needed
What it Does
How I Tested
Notes
Screenshot
Screenshot from the widget gallery
